0valt/1732/close reasons - #1737
Merged
Merged
Conversation
ArtOfCode-
approved these changes
Aug 4, 2025
Member
|
Approved but has conflicts. |
Member
Author
Yeah, due to #1733 - will solve shortly |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Oaphi
added
the
status: blocked
Oaphi
removed
the
status: blocked
ArtOfCode-
approved these changes
Aug 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1732
This PR ensures close reason names are validated for both minimum & maximum length (the latter is just so as crafty users aren't "rewarded" with a server error).
It also fixes lack of visible validation errors when trying to update (we've fixed the create action earlier) an invalid close reason: